[HDRP][Compositor] Do not allow users to directly reset/edit the compositor .asset file

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -765,6 +765,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed issue when Reflection Probes are set to OnEnable and are never rendered if the probe is enabled when the camera is farther than the probe fade distance. 
 - Fixed issue with sun icon being clipped in the look dev window. 
 - Fixed error about layers when disabling emissive mesh for area lights.
+- Fix issue when the user deletes the composition graph or .asset in runtime (case 1263319)
 
 ### Changed
 - Improve MIP selection for decals on Transparents
@@ -942,6 +943,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Changed the color space of EmissiveColorLDR property on all shader. Was linear but should have been sRGB. Auto upgrade script handle the conversion.
 - Preparation pass for RTSSShadows to be supported by render graph.
 - Add tooltips with the full name of the (graphics) compositor properties to properly show large names that otherwise are clipped by the UI (case 1263590)
+- Composition profile .asset files cannot be manually edited/reset by users (to avoid breaking things - case 1265631)
 
 ## [7.1.1] - 2019-09-05
 

com.unity.render-pipelines.high-definition/Editor/Compositor/CompositionUtils.cs

@@ -11,6 +11,14 @@ internal class CompositionUtils
     {
         public static readonly string k_DefaultCameraName = "MainCompositorCamera";
 
+        static public void RemoveCompositionProfileAsset(CompositionManager compositor)
+        {
+            if (compositor.profile)
+            {
+                AssetDatabase.DeleteAsset(AssetDatabase.GetAssetPath(compositor.profile));
+            }
+        }
+
         static public void LoadDefaultCompositionGraph(CompositionManager compositor)
         {
             if (!AssetDatabase.IsValidFolder("Assets/Compositor"))
@@ -112,6 +120,9 @@ static public void LoadOrCreateCompositionProfileAsset(CompositionManager compos
                 Debug.Log($"Loading composition profile from {path}");
             }
             compositor.profile = newProfile;
+
+            // [case 1265631] The profile asset is auto-generated by the compositor, so do not allow the users to manually edit/reset the values in the asset because it might break things. 
+            compositor.profile.hideFlags = HideFlags.NotEditable;
         }
     }
 }

com.unity.render-pipelines.high-definition/Editor/Compositor/CompositorWindow.cs

@@ -111,20 +111,28 @@ void OnGUI()
                 }
             }
 
-            if (compositor.profile == null)
+            if (compositor.shader == null)
             {
-                // The compositor was loaded, but there was no profile (someone deleted the asset from disk?), so create a new one
+                CompositionUtils.RemoveCompositionProfileAsset(compositor);
+                CompositionUtils.LoadDefaultCompositionGraph(compositor);
                 CompositionUtils.LoadOrCreateCompositionProfileAsset(compositor);
                 compositor.SetupCompositionMaterial();
-                return;
+                m_RequiresRedraw = true;
             }
-
-            if (compositor.shader != null)
+            else
             {
                 // keep track of shader graph changes: when the user saves a graph, we should load/reflect any new shader properties
                 GraphData.onSaveGraph += MarkShaderAsDirty;
             }
 
+            if (compositor.profile == null)
+            {
+                // The compositor was loaded, but there was no profile (someone deleted the asset from disk?), so create a new one
+                CompositionUtils.LoadOrCreateCompositionProfileAsset(compositor);
+                compositor.SetupCompositionMaterial();
+                m_RequiresRedraw = true;
+            }
+
             if (m_Editor == null || m_Editor.target == null || m_Editor.isDirty || m_RequiresRedraw)
             {
                 m_Editor = (CompositionManagerEditor)Editor.CreateEditor(compositor);

com.unity.render-pipelines.high-definition/Runtime/Compositor/CompositionManager.cs

@@ -258,7 +258,7 @@ bool ValidateAndFixRuntime()
 
             if (m_Shader == null)
             {
-                Debug.Log("The composition shader graph must be set");
+                Debug.Log("A composition shader graph must be set in the compositor window");
                 return false;
             }
 
@@ -392,12 +392,12 @@ public void SetupCompositionMaterial()
             // Create the composition material
             if (m_Shader)
             {
-                if (m_Material == null)
-                {
-                    m_Material = new Material(m_Shader);
-                }
+                m_Material = new Material(m_Shader);
 
                 m_CompositionProfile.AddPropertiesFromShaderAndMaterial(this, m_Shader, m_Material);
+
+                // [case 1265631] The profile asset is auto-generated by the compositor, so do not allow the users to manually edit/reset the values in the asset because it might break things
+                m_CompositionProfile.hideFlags = HideFlags.NotEditable;
             }
             else
             {