Expose bilateral blur aggressiveness for spatial SSAO blur when temporal accumulation #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Sep 2, 2020
|
Please update the screenshots on this PR, thanks |
Apparently screenshot did not change enough to warrant a new reference https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252Fexpose-bilateral-aggressiveness The only red was the XR tests, but unrelated reasons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Quality of life change, I expose here an aggressiveness factor of the bilateral blur. What that means is that the bilateral weights will be more or less lenient w.r.t depth differences.
This is somewhat content dependent on how much it is acceptable, so I expose it. For example in the graphics test you can see the difference (Zoomed a lot in)
Before (default, see left side)
New (with the new default btw)
I am running yamato and will update the PR as soon as I get the new images.