Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added precomputed velocity test #1582

Merged
merged 9 commits into from Aug 20, 2020

Conversation

JMargevics
Copy link
Contributor

@JMargevics JMargevics commented Aug 12, 2020

4014_PrecomputedVelocityAlembic

Added a 4014_PrecomputedVelocityAlembic automated test. Test uses alembic animations generated in Blender and checks if motion blur is correct.

Threshold raised to 0.001 from 0.0001 due to motion blur being slightly inconsistent.

Shaders checked:

  • Lit
  • Lit SG
  • Lit Tessellated
  • StackLit SG
  • Unlit
  • Unlit SG
  • Hair SG
  • Fabric SG
  • AxF
  • Eye SG

Motion blur with alembic animation
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@JMargevics JMargevics marked this pull request as draft August 12, 2020 15:40
@JMargevics JMargevics marked this pull request as ready for review August 12, 2020 15:40
@JMargevics JMargevics requested review from JulienIgnace-Unity and RemyUnity and removed request for RemyUnity August 19, 2020 14:48
Copy link
Contributor

@RemyUnity RemyUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green and seems ok.
I'm just curious about why I see some differences between APIs, but it's ok.

@RemyUnity RemyUnity merged commit bb6d939 into HDRP/staging Aug 20, 2020
@RemyUnity RemyUnity deleted the HDRP/tests/precomputed-velocity branch August 20, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants