Increase Raytracing Quality Keyword coverage for RT effects #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RR test, PT test, RT Shadow Test, Material Quality
sebastienlagarde
changed the base branch from
HDRP/staging
to
HDRP/rename-raytracing-node
|
merge in parent PR |
sebastienlagarde
added a commit
that referenced
this pull request
Sep 21, 2020
…ion (#1479) * Rename Raytracing Node to Raytracing Quality * Update Upgrading-from-2020.1-to-2020.2.md * Update documentation * Update TableOfContents.md * Update SGNode-Raytracing-Quality.md * Update CHANGELOG.md * adress feedback * Rename files * Update RayTracingQualityNode.cs * Update com.unity.render-pipelines.high-definition/Documentation~/Scalability-Manual.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Update com.unity.render-pipelines.high-definition/Documentation~/Scalability-Manual.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Update com.unity.render-pipelines.high-definition/Documentation~/SGNode-Raytracing-Quality.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Update com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Update com.unity.render-pipelines.high-definition/Documentation~/Upgrading-from-2020.1-to-2020.2.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Update com.unity.render-pipelines.high-definition/Documentation~/TableOfContents.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Updated raytracing node in 1000_Indirect * renamed default/ optimized to default / raytraced * fix compilation * update doc and screenshot * Update SGLit_RaytracingKeyword_Emission.shadergraph * update the code properly * update meta file * Increase Raytracing Quality Keyword coverage for RT effects (#1587) * Raytracing quality test coverage update RR test, PT test, RT Shadow Test, Material Quality * Update Indirect scene + ref image * update test for new code Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 1000_RaytracingQualityKeyword_PathTracer_Default.unity * Updated test scenes - added emission to test RTGI - added refraction color to test RT color shadows - recreated graph * Checked the test renderGraph Compatible * Fix issue with unlit shader * Update the test to add unlit case * Update 1000_RaytracingQualityKeyword_MaterialQuality_Indirect.png * Update 803_SubSurfaceScatteringGlobalIllumination.unity Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR increase the coverage of the raytracing quality keyword.
It tests :
Could not find a way to test RTAO with this, and RT SSS does not make real sense either.
Comments to reviewers
Needs to be merged AFTER this PR
This PR is actually on HOLD (draft) because there is a disagreement on how the raytracing quality keyword is supposed to work right now.