Add Depth Offset tests for Shadergraph Material types #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
RemyUnity
approved these changes
Sep 8, 2020
sebastienlagarde
approved these changes
Sep 8, 2020
|
hmm, weird, there is a failure unrelated to your change on mac in your change, you have only touch meta file. Maybe try to revert it to previous state? |
|
Yamato seems to be good now, I relaunched dx12 just to be sure. |
sebastienlagarde
added a commit
that referenced
this pull request
Sep 14, 2020
This reverts commit 4904a3e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR should cover Depth Offset functionality of all HDRP Shadergraph Material types(Lit, Unlit, StackLit, Fabric, Eye, Hair) as it seems no current tests cover this yet.
Yamato: (Select your branch):
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252Ftests%252FdepthOffset/.yamato%252Fall-hdrp.yml%2523All_HDRP_trunk/3111315/job