[HDRP][Compositor] Update the compositor output when not in play mode #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-chapelain
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Issue seems to be fixed. ✔️
The only concern I had was performance since now the game view and thumbnails are refreshed @4fps but according to @pmavridis, no major difference has been detected ✔️
sebastienlagarde
approved these changes
Sep 8, 2020
sebastienlagarde
added a commit
that referenced
this pull request
Sep 18, 2020
This reverts commit a3d14c4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1266216/
The problem in the bug ticket is caused because SSR look black on the first rendered frame, because we don't have a valid color pyramid history. This behavior is also true outside of the compositor (can repro in scene view by toggling SSR with "always refresh" set to off).
The first rendered frame might have other issues too: for example TAA will not have converged yet and any effects that require denoising/accumulation will probably not look ok and exposure might not be 100% accurate.
From the compositor side, the real problem was that the preview/output was restricted to the first rendered frame, unless the user was in play mode (or unless the game view was side-by-side with scene view and "always refresh" was enabled). This PR makes sure that the compositor output gets regular updates and is not stuck in the first frame.
Testing status