Fixed an issue with TAA history management on pssl. #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anisunity
requested review from
JulienIgnace-Unity,
RemyUnity and
FrancescoC-unity
|
It appears that you made a non-draft PR! |
FrancescoC-unity
approved these changes
Aug 25, 2020
JulienIgnace-Unity
approved these changes
Aug 25, 2020
RemyUnity
approved these changes
Sep 8, 2020
sebastienlagarde
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On PSSL, an history management problem was found on the HDRP template.
High quality TAA caused a crash and Medium Quality was giving the wrong result (Screenshot).
Testing status
After the fix, the issue doesn't appear anymore on medium and high doesn't crash anymore.