New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Light Unit Slider (Light Intensity, Temperature, Exposure) #1691
Conversation
…placement of markers
… descriptor, implement the exponential light unit slider
Hi @iM0ve, thanks for the extra review. To address your notes:
|
Hi @fredericv-unity3d, thanks also for your review. Your notes should all be addressed (note: for your note regarding Humanizing tooltip value, there is ongoing discussion with artists if it should be abbreviated or not). If it's alright, I will request another re-review. I just pushed one last significant change to the slider that makes it always operate internally in Lumen. This was done to directly fix @iM0ve feedback number 8. It removed a lot of code (in the settings), added a slider specifically for converting between light units, and it elevated the access level of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found very minor issues that should be changed, can you update them?
com.unity.render-pipelines.high-definition/Editor/Lighting/LightUnit/LightUnitSlider.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Editor/Lighting/LightUnit/LightUnitSlider.cs
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Editor/Lighting/LightUnit/LightUnitSlider.cs
Outdated
Show resolved
Hide resolved
You can request as many reviews as you need, it is always helpful! |
No new issues found. Updated the review. Only issue 5 still remains. Overall PR is looking good. I will wait for all the changes to land and do one last check before approving. |
…or (keeping the slider constant between light unit)
Thanks @fredericv-unity3d - I implemented your requests, and also added one last improvement that should satisfy the request of the artists (basically, need to satisfy the case of spot reflector; where the slider should be unchanged between light units). There was an unfortunate limitation to the |
Hi @iM0ve, for issue 5, it's certainly a doable change but I haven't been able to confirm alignment on it with UX. Additionally, I assume the change would also require new icons which I don't think are currently on hand from icon artist. If the change to the tooltip is enough however, it should be quickly doable. Note also: I pushed a change to the light intensity slider that should be an improvement for how it behaves with spot reflector. Its probably the area of most attention in your next round of testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for me!
Note: This PR now fully implements the originally designed spec. However, we have the following feedback from artists:
|
Hey, so I will merge the current PR and we will do the improvement in a following one. THanks |
arf sorry about that. was guessing it was done. Good catch |
Purpose of this PR
This PR introduces the proposed improvement to UI/UX for light units. It adds a new slider UI drawer that loads a table of helpful value ranges, providing more context to the user about light unit values; through icons, markers, and tooltips. This will help the user to more easily reason about the variety of physically based values in HDRP, when authoring lighting and exposure.
Light Intensity Units (EV, Nits, Lumen, Candela, Lux)
Temperature Units (Kelvin)
Exposure Units (EV)
Editor Theme
Slider is constant across all punctual light intensity units and spot reflector
Testing status
Comments to reviewers