Fixed RTGI getting noisy for grazying angle geometry (case 1266462). #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
iM0ve
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Approved.
The noisiness at grazing angles is lower, as intended. See the comparison below:
Before:
After:
I also found that with default settings the overall image is less blurry
Before:
After:
Whats tested:
- If bug case is resolved (first comparison)
- If there was a regression in RTGI quality (second comparison). The quality of GI noticeably increased not only from grazing angles.
- If there is performance regression. On custom DXR office demo project, before and after PR I had the same ~27fps, on 720p.
- Checked all Screen Space Global Illumination parameters still work
- Verified that second denoise radius was removed
iM0ve
requested changes
Sep 8, 2020
sebastienlagarde
approved these changes
Sep 8, 2020
|
Doc updated |
iM0ve
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://fogbugz.unity3d.com/f/cases/1266462/
Purpose of this PR
This PR tries to improve the denoising of RTGI to get rid of high frequency noise at grazing angles. While there is no miracle solution. The changes in this PR should help reduce that artifacts.
This PR also removes the second denoiser radius that is now deduced from the first denoiser radius.
The PR should be tested extensively by the QA who reported the issue to see if this is overall an improvement.
Testing status
The DXR tests are green after updating the screenshots.
I tested mainly on the scene that was used to report the issue and after the fix I was not able to repro the high frequency noise.