Fix issue with stencil in rendergraph #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
| @@ -270,8 +271,7 @@ void BindMotionVectorPassColorBuffers(in RenderGraphBuilder builder, in PrepassO | |||
| // NOTE: Currently we profiled that generating the HTile for SSR and using it is not worth it the optimization. | |||
| // However if the generated HTile will be used for something else but SSR, this should be made NOT resolve only and | |||
| // re-enabled in the shader. | |||
| if (hdCamera.IsSSREnabled()) | |||
There was a problem hiding this comment.
why if (hdCamera.IsSSREnabled()) have disappeard?
There was a problem hiding this comment.
As discussed with Julien during our call, this is redundant in Rendergraph as the pass will be automatically culled.
sebastienlagarde
added a commit
that referenced
this pull request
Sep 14, 2020
This reverts commit 01ba90c.
sebastienlagarde
added a commit
that referenced
this pull request
Sep 16, 2020
This reverts commit 5bd028c.
sebastienlagarde
added a commit
that referenced
this pull request
Sep 16, 2020
This reverts commit fc56d9e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue that prevented the stencil to be set if BuildCoarseStencilAndResolveIfNeeded was not called.
Added a comment on top of BuildCoarseStencilAndResolveIfNeeded and removed SSR check as rendergraph will automatically cull passes.