Fix when camera is on the planar reflection plane #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-de-tocqueville
requested review from
sebastienlagarde and
TomasKiniulis
|
Isn't this the same as #1537 ? |
|
That seems related but I can't reproduce the bug you fixed when disabling your fix (I don't know what i'm doing wrong), so I don't know if mine would fix it too |
sebastienlagarde
approved these changes
Sep 11, 2020
TomasKiniulis
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
This change seems to fix it. Checked repro project. Made sure that Out Of Frustum Errors do not occur baking Reflection Probe when:
- Planar probe and reflection probe are at 0 Y coordinate, are shared above or below
- Main Camera, Planar Probe, Reflection Probe share the exact same coordinate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix for https://fogbugz.unity3d.com/f/cases/1276072/
When the camera is exactly on the planar reflection probe plane, the reflected camera has some weird values so I just offset the camera position along the mirror normal.