Added debug immediate mode for Render Graph #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienIgnace-Unity
requested review from
sebastienlagarde and
FrancescoC-unity
|
It appears that you made a non-draft PR! |
…https://github.com/Unity-Technologies/Graphics into HDRP/rendergraph-immediate-mode
…Graphics into HDRP/rendergraph-immediate-mode
sebastienlagarde
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Added debug immediate mode for Render Graph.
In this mode all passes are executed as they are added. This allows for easier debugging.
Be aware that in this mode, as we don't have the full picture of the frame, more resources will be allocated.
Had to make a few fixes to make it work.
Testing status
Manual Tests: What did you do?
Also ran the HDRP tests with immediate mode.
Only a few minor differences in some DoF related tests caused by a faulty guard band implementation exhibit by having different render targets than in the regular code path (not related to RG specifically).