Fix for objects using Eye shaders not appearing on xbox one. #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Sep 23, 2020
sebastienlagarde
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a while to pin point, but apparently attempting to make the shadow index uniform in the area light shadow code triggers bad code generation in FXC. I am told that we cannot expect fxc to get fixes, hence we will just skip this scalarization part (hopefully is not going to be too impactful given that if we have area lights VGPRs have already exploded by that point) on xbox.
Yamato: https://yamato.cds.internal.unity3d.com/jobs/339-ScriptableRenderPipelinePrivate/tree/HDRP%252Ffrancesco-test/.yamato%252Fupm-ci-hdrp_standalone.yml%2523Run_XboxOne_trunk/3525309/job
Note: the test still fails as planar reflections look different, but so does master and any version I could see on yamato. We should have a quick chat