View Space Lighting Tool #2691
Merged
View Space Lighting Tool #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HDRP/ViewSpaceLightingTool
…HDRP/ViewSpaceLightingTool
…HDRP/ViewSpaceLightingTool
JordanL8
suggested changes
Nov 20, 2020
com.unity.render-pipelines.core/Documentation~/View-Lighting-Tool.md
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Documentation~/View-Lighting-Tool.md
Outdated
Show resolved
Hide resolved
…ogies/Graphics into HDRP/ViewSpaceLightingTool
…HDRP/ViewSpaceLightingTool
JordanL8
reviewed
Nov 23, 2020
com.unity.render-pipelines.core/Editor/Lighting/GUIFramework/ClickAction.cs
Outdated
Show resolved
Hide resolved
JordanL8
reviewed
Nov 23, 2020
com.unity.render-pipelines.core/Editor/Lighting/GUIFramework/ClickAction.cs
Outdated
Show resolved
Hide resolved
JordanL8
reviewed
Nov 23, 2020
com.unity.render-pipelines.core/Editor/Lighting/GUIFramework/ClickAction.cs
Outdated
Show resolved
Hide resolved
JordanL8
reviewed
Nov 23, 2020
com.unity.render-pipelines.core/Editor/Lighting/GUIFramework/ClickAction.cs
Outdated
Show resolved
Hide resolved
JordanL8
reviewed
Nov 23, 2020
com.unity.render-pipelines.core/Editor/Lighting/GUIFramework/ClickAction.cs
Outdated
Show resolved
Hide resolved
JordanL8
reviewed
Nov 23, 2020
com.unity.render-pipelines.core/Editor/Lighting/GUIFramework/ClickAction.cs
Outdated
Show resolved
Hide resolved
RSlysz
requested changes
Jan 12, 2021
There was a problem hiding this comment.
Looks better.
Though, make sure you are compliant with L10n
https://confluence.unity3d.com/display/LOC/Editor+Localization+Coding+Guidelines
com.unity.render-pipelines.core/Editor/Lighting/LightAnchorEditor.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Editor/Lighting/LightAnchorEditor.cs
Outdated
Show resolved
Hide resolved
…HDRP/ViewSpaceLightingTool # Conflicts: # com.unity.render-pipelines.core/Editor/Lighting/Icons/DebugProbe.fbx # com.unity.render-pipelines.core/Editor/Lighting/Icons/DebugProbe.fbx.meta # com.unity.render-pipelines.core/Editor/Lighting/Icons/InstancedProbeShader.shader # com.unity.render-pipelines.core/Editor/Lighting/Icons/InstancedProbeShader.shader.meta
RSlysz
approved these changes
Jan 12, 2021
remi-chapelain
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
Confluence test page has been updated, last (must fix) bug has been fixed, Approving ! ✔️
Still have some concerns about users that will want to use the tool with timeline or at runtime. I have gathered some feedback from artists that could see that as an improvement in the future. We'll see depending on the users usage and feedback to see if that makes sense !
JordanL8
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a ViewSpace Lighting Tool (Game Camera Only)
Why the PR's needed?
Give a tool that help the lighter to light the scene directly on the Scene View, which is very convenient to setup cutscene, cinematics, ... For M&E, Chaplin, ....
[Post-UX Pass]
What's tested?
Move the light orientation & distance (in the component), notice the lighting in the GameView
What needs more testing?
https://docs.google.com/document/d/1psNwpqBTKp3SISTEA7nKu0UoUPiIy7jCN1OEddNEL08/edit
Which allow to place light relative to camera space (Game Camera Only).
The last knob will control the rotation of the cookie
Adding a tool for LightAnchor:
Which change the gizmo to be on the target to place easily the target: