Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom pass normal and template #2716

Merged
merged 5 commits into from
Nov 23, 2020
Merged

Fix custom pass normal and template #2716

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
56069a2
Fix custom pass template not compiling
alelievr Nov 20, 2020
683684a
Fix custom pass normal buffer not bound
alelievr Nov 20, 2020
e71dcb7
Updated changelog
alelievr Nov 20, 2020
9e0ec91
Merge branch 'hd/bugfix' into hd/fix/custom-pass-normal-and-template
sebastienlagarde Nov 23, 2020
da28887
Update CHANGELOG.md
sebastienlagarde Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed issue with exposure history being uninitialized on second frame.
- Fixed issue when changing FoV with the physical camera fold-out closed.
- Fixes some labels being clipped in the Render Graph Viewer
- Fixed normal buffer not bound to custom pass anymore.

### Changed
- Combined occlusion meshes into one to reduce draw calls and state changes with XR single-pass.
Expand Down
1 change: 1 addition & 0 deletions ...lines.high-definition/Editor/RenderPipeline/CustomPass/CustomPassRenderersShader.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ Shader "Renderers/#SCRIPTNAME#"

// Write back the data to the output structures
ZERO_INITIALIZE(BuiltinData, builtinData); // No call to InitBuiltinData as we don't have any lighting
ZERO_INITIALIZE(SurfaceData, surfaceData);
builtinData.opacity = opacity;
builtinData.emissiveColor = float3(0, 0, 0);
surfaceData.color = color;
Expand Down
3 changes: 3 additions & 0 deletions ...nder-pipelines.high-definition/Runtime/RenderPipeline/RenderPass/CustomPass/CustomPass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,9 @@ internal void ExecuteInternal(RenderGraph renderGraph, HDCamera hdCamera, Cullin
if (customPass.currentRenderTarget.motionVectorBufferRG.IsValid() && (customPass.injectionPoint == CustomPassInjectionPoint.BeforePostProcess || customPass.injectionPoint == CustomPassInjectionPoint.AfterPostProcess))
ctx.cmd.SetGlobalTexture(HDShaderIDs._CameraMotionVectorsTexture, customPass.currentRenderTarget.motionVectorBufferRG);

if (customPass.currentRenderTarget.normalBufferRG.IsValid() && customPass.injectionPoint != CustomPassInjectionPoint.AfterPostProcess)
ctx.cmd.SetGlobalTexture(HDShaderIDs._NormalBufferTexture, customPass.currentRenderTarget.normalBufferRG);

if (!customPass.isSetup)
{
customPass.Setup(ctx.renderContext, ctx.cmd);
Expand Down