Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HDRP] Updated what's new in HDRP 11 #2750

Merged
merged 3 commits into from Nov 26, 2020

Conversation

alelievr
Copy link
Member

Purpose of this PR

Update What's new with cubemap field change in volumes

@alelievr alelievr self-assigned this Nov 25, 2020
@github-actions github-actions bot added the HDRP label Nov 25, 2020
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

Copy link
Contributor

@JordanL8 JordanL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased some bits, can you double-check the first sentence "Cubemap fields now... etc" to make sure I understood it correctly before merging?

@sebastienlagarde
Copy link
Collaborator

Cubemap fields now accept both RenderTextures and >CustomRenderTextures if they are formatted like Cubemaps. >This change affects the HDRI Sky and Physically Based Sky components and allows you to animate both skies.

the " if they are formatted like Cubemaps." is still weird. @alelievr what do you suggets?

@alelievr
Copy link
Member Author

Hum, " if they are using the cubmap mode / dimension" would be better I think (dimension is the correct renderTexture property name)

@sebastienlagarde
Copy link
Collaborator

Hum, " if they are using the cubmap mode / dimension" would be better I think (dimension is the correct renderTexture property name)

@JordanL8 ?

@JordanL8
Copy link
Contributor

Ah sorry I didn't get any notifications for this. Yeah if cubemap mode / dimension is more correct then sounds good :)

@JordanL8
Copy link
Contributor

I'll update this

@JordanL8
Copy link
Contributor

JordanL8 commented Nov 26, 2020

... if they use the cubemap mode / dimension. ...

All good?

@alelievr
Copy link
Member Author

Yeah :)

@sebastienlagarde sebastienlagarde merged commit 04638c7 into master Nov 26, 2020
@sebastienlagarde sebastienlagarde deleted the hd/cubemap-fields-whats-new branch November 26, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants