Normalize view direction in universal #2752
Conversation
|
It appears that you made a non-draft PR! |
…rsal. Needs to be verified in HD as well
…Unity-Technologies/Graphics into sg/normalize-view-direction-shared-code
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| Provides access to the mesh vertex or fragment's **View Direction** vector. This is the vector from the vertex or fragment to the camera. The coordinate space of the output value can be selected with the **Space** dropdown parameter. | |||
|
|
|||
| NOTE: In versions prior to 11.0, the **View Direction** vector was not normalized in the **Universal Render Pipeline**. Version 11.0 changed this behavior, and this vector is now normalized in both the **High-Definition Render Pipeline** and the **Universal Render Pipeline**. To mimic old behavior, you can use the [Position Node](Position-Node.md) in **World** space and subtract the **Position** output of the [Camera Node](Camera-Node.md). | |||
There was a problem hiding this comment.
Do you know if the camera position output in (local) World space in HDRP? (i.e. 0,0,0) ?
There was a problem hiding this comment.
Yeah, that was something i wan going to have to double check in HDRP. I think you are right tho, and will address it
There was a problem hiding this comment.
This wording is getting changed tho, since weve added the new node
|
@LandonTownsendUnity the feedback was addressed can you look at this PR again? |
We are also waiting on updated Documentation for the node before we can merge |
ghost
self-requested a review
There was a problem hiding this comment.
I'm OK with the "view vector" object mode behavior being different because the old view direction behavior was normalized and that doesn't make sense for a "view vector" node. However it should be stated in the upgrade guide/documentation that you shouldn't swap out the node if it's in object space.
The behavior of "View Vector" is different from the old behavior of View Direction when in orthographic camera mode, in all spaces. This needs to be fixed. Even aside from upgrade problems, "view vector" being the vector from the position to the camera doesn't make sense in orthographic mode.
ghost
self-requested a review
ghost
self-requested a review
There was a problem hiding this comment.
Validated both the length and direction in all possible combinations of
HDRP and URP
Orthographic and Perspective
Object, View, World, and Tangent space
My only worry is that someone will be relying on the behavior of the view direction being normalized in orthographic but not in perspective... however this seems like a very unlikely scenario.
Docs need the following changes:
- Documentation for the View Vector node needs to be added
- Documentation for the View Direction node needs to be updated to tell people to use the View Vector node
- Documentation for the View Direction node should specify that View Direction was in fact normalized in object mode prior to this fix, and that if a view direction node was in object mode, do not swap it out for the view vector node.
ghost
self-requested a review
ghost
self-requested a review
Needed to have the view direction node return a normalized value in Shader Graph. Created templates in the Universal package to achieve this.
Ran all Shader Graph tests locally and verified normalized view direction in editor