Introduce concept of falling back textures to black in rendergraph + ReadWrite tag #2762
Conversation
FrancescoC-unity
requested review from
sebastienlagarde,
JulienIgnace-Unity,
anisunity and
a team
| RenderGraphDebugParams m_RenderGraphDebug; | ||
| RenderGraphLogger m_Logger; | ||
| int m_CurrentFrameIndex; | ||
| TexturePool m_TexturePool = new TexturePool(); |
There was a problem hiding this comment.
Yikes visual studio, gonna revert this spacing change
|
I don't really know what those changes might do or affect, do you have any hint about what additional tests of check QA should do ? |
com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraphBuilder.cs
Show resolved
Hide resolved
com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraphBuilder.cs
Show resolved
Hide resolved
| @@ -798,7 +799,10 @@ void RenderDBuffer(RenderGraph renderGraph, HDCamera hdCamera, TextureHandle dec | |||
| passData.parameters = PrepareRenderDBufferParameters(hdCamera); | |||
| passData.meshDecalsRendererList = builder.UseRendererList(renderGraph.CreateRendererList(PrepareMeshDecalsRendererList(cullingResults, hdCamera, use4RTs))); | |||
| SetupDBufferTargets(renderGraph, passData, use4RTs, ref output, builder); | |||
| passData.decalBuffer = builder.ReadTexture(decalBuffer); | |||
| if (hdCamera.frameSettings.IsEnabled(FrameSettingsField.DecalLayers)) | |||
There was a problem hiding this comment.
Leftovers from previous tests?
We talked about the dbuffer pass directly returning black if possible to remove this logic (and in the render pass itself)
There was a problem hiding this comment.
Yes, will change that, was planning on doing a sanity check on stuff like that later, but might as well fix this one now.
|
@RemyUnity not much aside the repro case I think, there is nothing user facing that won't be caught by automation I think |
|
From what I read, it looks good to me, didn't test it locally though |
# Conflicts: # com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraphResourceRegistry.cs # com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraphResources.cs # com.unity.render-pipelines.high-definition/CHANGELOG.md # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
This among a more general thing fixes: https://fogbugz.unity3d.com/f/cases/1295272/
The issue was that because normal buffer is set globally is marked as read in the transparency pass. However, if no opaque objeccts were defined, the texture handle would be valid (we create it outside passes), but the content won't be as it was never written to.
Instead of fixing the specific case, I introduced the concept of write count and fall back to black texture whenever the above case happens and that should happen automagically whenever a texture is declared to have such behaviour. This logic needs to be on the Rendergraph resource to avoid issues when an handle is copied around but is not updated.
On top of that, since it is important for the mechanism that all Reads are defined after a Write, I replaced the somewhat ugly pattern of builder.ReadTexture(builder.WriteTexture(...)) with a compact builder.ReadWriteTexture(...)
What did I test: the repro case and all the DXR tests (most of the ReadWrite code was in DXR)