Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide shadow resolution value #3335

Merged
merged 1 commit into from Feb 1, 2021

Conversation

adrien-de-tocqueville
Copy link
Contributor

Purpose of this PR

Goal is to have the same dropdown for shadow resolution bewteen cloud layer and vloumetric clouds following a request from qa

@github-actions
Copy link

github-actions bot commented Feb 1, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde changed the base branch from hd/bugfix to master February 1, 2021 18:43
@sebastienlagarde sebastienlagarde changed the base branch from master to hd/bugfix February 1, 2021 18:45
@sebastienlagarde sebastienlagarde merged commit fe86016 into hd/bugfix Feb 1, 2021
@sebastienlagarde sebastienlagarde deleted the hd/cloud-layer-shadow-quality branch February 1, 2021 18:45
@remi-chapelain
Copy link
Contributor

remi-chapelain commented Feb 2, 2021

Still commenting even if this is already merged but there was a few more things we discussed to change in this overrides to try and be consistent with the volumetric clouds one :

  • - Use Low / Med / High for shadow resolution (done in this PR)
  • Add information on the tooltip when enabling shadows that the shadow will override the dir light cookie (you can't have both shadows from two clouds systems) here's the current tooltip from volumetric clouds : "Enable/Disable the volumetric clouds shadow. This will override the cookie of your directional light and the cloud layer shadow (if active)."
  • Change Scroll Direction to Scroll Orientation to be consistent with the now Wind Orientation in the override
  • Finally, @adrien-de-tocqueville told me that cloud dropdown in Visual Environment override is there to pick between the two clouds solution, BUT since both override can work together (top clouds sheet with cloud layer and medium and low level with volumetric clouds), should we just remove the dropdown from visual environment that implies they're both mutually exclusive ?

@adrien-de-tocqueville
Copy link
Contributor Author

should we just remove the dropdown from visual environment that implies they're both mutually exclusive ?

It's still possible for users to make custom clouds with it. We should rathe make it explicit that volumetric clouds are not selected from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants