Updated documentation of RequestRenderNextUpdate #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanL8
suggested changes
Feb 3, 2021
| @@ -27,6 +27,8 @@ public static class HDAdditionalReflectionDataExtensions | |||
| /// be rendered the next time it will influence a camera rendering. | |||
| /// | |||
| /// If the probe don't have a <see cref="HDAdditionalReflectionData"/> component, nothing is done. | |||
| /// | |||
| /// Note: A camera is influenced by a probe if the camera's frustum intersects the probe's influence volume. | |||
There was a problem hiding this comment.
Note: If any part of a Camera's frustum intersects a Reflection Probe's influence volume, the Reflection Probe influences the Camera.
|
@fredericv-unity3d any update? |
|
@fredericv-unity3d can you update this PR? thanks |
|
Sorry for the delay, the github notification was lost somehow |
JordanL8
approved these changes
Feb 17, 2021
sebastienlagarde
deleted the
hd/bugfix_request_render_next_update_doc
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Added information to a method documentation for better understanding. (See https://fogbugz.unity3d.com/f/cases/1290521).
Testing status
No code was changed, only the documentation.
Comments to reviewers
Doc: please review the modified documentation.