Universal/Enlighten Realtime GI support #3386
Conversation
a generic one was added upstream
There was a problem hiding this comment.
I have finished an extensive review pass on the feature. For more details on testing methodology, please refer to the dedicated feature test document.
No major issues were found while testing. Great work! Approved.
Template images are up to date now after dealing with the merge of the project split. |
| half3 bakedGI = SampleLightmap(input.LightmapUV, half3(0.0, 1.0, 0.0)); | ||
|
|
There was a problem hiding this comment.
How are we getting ambient skylight / SH?
There was a problem hiding this comment.
I ended up bringing the code back here 95e5f15 but in a more generic shape so SH sampling is possible for terrain details.
|
Is mobile manual testing planned? I have concerns about additional varyings in shadergraph as they are not handling packing that well at it might result in more interpolators now. |
| StructFields.Varyings.positionWS, | ||
| StructFields.Varyings.normalWS, | ||
| StructFields.Varyings.tangentWS, // needed for vertex lighting | ||
| StructFields.Varyings.viewDirectionWS, | ||
| UniversalStructFields.Varyings.lightmapUV, | ||
| UniversalStructFields.Varyings.staticLightmapUV, | ||
| UniversalStructFields.Varyings.dynamicLightmapUV, |
There was a problem hiding this comment.
I have concerns here regarding the shadergraph as they do not handle conditional interpolator packing that well. So it might result more interpolators even with disabled varyings. I think we need mobile test pass to be sure on that
Before, only lightmaps were sampled but SH makes more sense for terrain details. Instead of deleting the lightmap sampling code, this makes it more generic so both lightmap or SH can be used.
Fixed here 95e5f15 |
aleksandrasdzikia
requested review from
aleksandrasdzikia
and removed request for
a team
Purpose of this PR
Add Enlighten Realtime GI support to Universal. Makes it easier to upgrade from builtin render pipeline.
Testing status
Tech art validation pass completed. Details here https://jira.unity3d.com/browse/GFXGI-401.
SRP batcher has been tested and fixed.
Automated test coverage has been added in the following scenes:
150_Lighting_EnlightenEmission
151_Lighting_EnlightenLights
152_Lighting_EnlightenEnvironment
153_Lighting_EnlightenTerrain
Forward and deferred rendering path is covered by the tests.
Tests are covering Editor and Standalone Player on desktops and mobile platforms across DX11, DX12, Vulkan, Metal and GLES3.0.
Realtime GI has been disabled in all other scenes (separate PR, already landed in master).
Comments to reviewers
Material inspector has been streamlined to work like the build in one (user can now choose between baked and realtime GI emission).
Documentation has been updated.
Jira task https://jira.unity3d.com/browse/GFXGI-394