Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deferred GraphicsTest Automation #3519

Merged
merged 55 commits into from
Mar 10, 2021
Merged

Deferred GraphicsTest Automation #3519

merged 55 commits into from
Mar 10, 2021

Conversation

cinight
Copy link
Contributor

@cinight cinight commented Feb 16, 2021 •
edited

Purpose of this PR

We don't have deferred test scenes in master.
This PR makes Deferred Graphics Test scenes automated.

Deferred test scene list

UniversalGraphicsTest_Foundation

  • 001_SimpleCube_deferred
  • 007_LitShaderMaps_deferred
  • 010_AdditionalLightsSorted_Deferred
  • 014_CameraMulti_MiniMap_deferred
  • 015_CameraMulti_FPSCam_deferred
  • 111_CameraStackMSAA_deferred
  • 123_CameraStackingClear_deferred
  • 012_PBS_EnvironmentBRDF_Spheres_deferred
  • 026_Shader_PBRscene_AccurateGBuffer
  • 029_Particles_Deferred
  • 050_Shader_Graphs_deferred
  • 129_CameraStack3DOnUI_deferred
  • 130_ClearCoat_deferred

UniversalGraphicsTest_Terrain

  • 035_Shader_TerrainShaders_deferred
  • 038_Shader_TerrainBlend_deferred (Deferred has a bug - case 1318364)

UniversalGraphicsTest_Lighting

  • 023_Lighting_Mixed_Indirect_deferred
  • 043_Lighting_Mixed_ShadowMask_deferred
  • 049_Lighting_Mixed_Subtractive_deferred

UniversalGraphicsTest_PostPro

  • 145_SoftParticlesStackWithPP_deferred
  • 145_SSAO_Deferred_Projection (exists already)
  • 146_SSAO_Deferred_Orthographic (exists already)
  • 147_SSAO_Deferred_RenderToBackBuffer (exists already)

Testing

I've double checked each deferred test scenes I created are really running with DeferredRenderer.

On Yamato: All green. 🟢🟢🟢🟢

Note to reviewers

This PR also changed these existing Forward tests:

  • 050_Shader_Graphs
    • this is disabled on Master but this PR enables it
    • updated ReferenceImages
    • for details please see Bug 04 in document
  • 130_ClearCoat
    • this PR only updated ReferenceImages for Iphone Metal
    • disable TestRunnerBake label
    • reason please see Bug 02 in document
  • 038_Shader_TerrainBlend
    • this PR only updated ReferenceImages for Standalone platforms
    • details please see Bug 01 in document

Please visit this document for any other details.

@cinight cinight mentioned this pull request Feb 16, 2021
Closed
@cinight
Duplicated scenes for deferred
e9f9642
@cinight
Ref imgs for the duplicated deferred scenes
40c6534
@cinight
adding Post Pro 145 deferred scene
46f79f2
@cinight
adding Terrain 035 deferred scene
dd2fcda
@cinight
Add Lighting 023, 043, 049 deferred scenes
f1a7261
@cinight
Fix Terrain ref imgs
6628a4a
@cinight
fix Lighting 043
bb0981c
@cinight
Fix Terrain Vulkan ref img
ff7792f
@cinight
Fix Foundation 130
de15274
@cinight
Fix Foundation 130 and Vulkan ref img
0255175
@cinight
Fix Foundation 130 again
15ba6fe
@cinight
Fix Founation Linux Vulkan player ref img
070e365
@cinight
Fix Terrain Android ref img
88f3ab8
@cinight
Fix Foundation mobile ref imgs
1f5c817
@cinight
Fix Foundation 130
907767a
@cinight
Fix Lighting 023 deferred
0993cd9
@cinight
Merge branch 'master' into universal/deferred-tests-splitted
43e5d97
@cinight
Foundation 130 again
5a0a0bd
@cinight
Foundation 026 deferred turn off lighting filter mode
800b9fd
@cinight
Foundation 130
d0c8eed
@cinight
Foundation 130 - revert lighting data
0be1705
@cinight
Foundation remove 130 autobake
4fc9706
@cinight
Fix Foundation 029 filter mode
7d8cd31
@cinight cinight marked this pull request as ready for review March 1, 2021 16:13
@cinight
Merge branch 'master' into universal/deferred-tests-splitted
79a8ecc
@cinight
Merge branch 'master' into universal/deferred-tests-splitted
5f9c8a8 
# Conflicts:
#	TestProjects/UniversalGraphicsTest_Foundation/Assets/CommonAssets/UniversalRPAsset.asset
#	TestProjects/UniversalGraphicsTest_Lighting/Assets/CommonAssets/UniversalRPAsset.asset
@cinight
Fix Foundation deferred renderer
ee494aa
@cinight
Fix Terrain Deferred Renderer
0e045c1
@cinight
Fix Lighting Deferred Renderer
f51c655
@cinight
Fix PostPro Deferred Renderer
ed94239
@cinight cinight requested review from kaychang-unity, sophiaaar and a team March 4, 2021 15:15
kaychang-unity
kaychang-unity approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@kaychang-unity kaychang-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the test scenes!

simon-engelbrecht-soerensen
simon-engelbrecht-soerensen approved these changes Mar 5, 2021
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green on my end.

@cinight
Copy link
Contributor Author

cinight commented Mar 5, 2021

Will resolve conflict and run test again

@cinight cinight requested a review from a team March 5, 2021 10:47
@cinight
Merge branch 'master' into universal/deferred-tests-splitted
2e1c11d 
# Conflicts:
#	TestProjects/UniversalGraphicsTest_Lighting/Assets/CommonAssets/UniversalRPAsset.asset
@cinight
Fix Lighting deferred renderer
91c1410
@phi-lira phi-lira merged commit 242cc7d into master Mar 10, 2021
@phi-lira phi-lira deleted the universal/deferred-tests-splitted branch March 10, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-engelbrecht-soerensen simon-engelbrecht-soerensen simon-engelbrecht-soerensen approved these changes

@phi-lira phi-lira phi-lira approved these changes

@sophiaaar sophiaaar sophiaaar approved these changes

@kaychang-unity kaychang-unity kaychang-unity approved these changes

Assignees
No one assigned
Labels
testing universal
Projects
None yet
Milestone
No milestone
5 participants
@cinight @simon-engelbrecht-soerensen @phi-lira @sophiaaar @kaychang-unity