Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PPv2] Fixes for Mobile & WebGL platforms #3720

Merged
merged 4 commits into from
Mar 2, 2021
Merged

[PPv2] Fixes for Mobile & WebGL platforms #3720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d9f78d
Fix for compilation error in the FinalPass shader with GLES2/WebGL1 (…
Chman Mar 2, 2021
bfe5d3b
Fix for MSVO errors on unsupported Android platforms (case 1316915)
Chman Mar 2, 2021
17568ef
Version update
Chman Mar 2, 2021
e7f9cd0
Version update (back to 3.1.0, not published yet)
Chman Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion com.unity.postprocessing/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ All notable changes to this package will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [3.1.0] - 2021-02-20
## [3.1.0] - 2021-03-02

### Added
- Support for the PlayStation 5 platform has been added.
Expand All @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Fixed
- Fix for issue thrown upon unloading a scene from an AssetBundle (case 1262826)
- Fix for MSVO when used with dynamic resolution reallocating temporary render targets whenever the dynamic resolution scale was changed which could cause a higher peak VRAM usage and fragmentation (Case 1285605). Temporary targets will now use dynamic scaling as well to solve this. Please note there is a bug in Unity that breaks this fix (case 1285577) To make use of dynamic resolution and MSVO please use Unity 2019.4.19f1, 2020.2.2f1, 2021.1.0a9 or later.
- Fix for compilation error in the FinalPass shader with GLES2/WebGL1 (case 1311160)
- Fix for MSVO errors on unsupported Android platforms (case 1316915)

## [3.0.3] - 2021-02-19

Expand Down
7 changes: 4 additions & 3 deletions com.unity.postprocessing/PostProcessing/Runtime/Effects/AmbientOcclusion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using UnityEngine.Experimental.Rendering;

namespace UnityEngine.Rendering.PostProcessing
{
Expand Down Expand Up @@ -189,9 +190,9 @@ public override bool IsEnabledAndSupported(PostProcessRenderContext context)

state &= SystemInfo.supportsComputeShaders
&& !RuntimeUtilities.isAndroidOpenGL
&& RenderTextureFormat.RFloat.IsSupported()
&& RenderTextureFormat.RHalf.IsSupported()
&& RenderTextureFormat.R8.IsSupported();
&& SystemInfo.IsFormatSupported(GraphicsFormat.R32_SFloat, FormatUsage.Render | FormatUsage.LoadStore)
&& SystemInfo.IsFormatSupported(GraphicsFormat.R16_SFloat, FormatUsage.Render | FormatUsage.LoadStore)
&& SystemInfo.IsFormatSupported(GraphicsFormat.R8_UNorm, FormatUsage.Render | FormatUsage.LoadStore);
}

return state;
Expand Down
4 changes: 2 additions & 2 deletions com.unity.postprocessing/PostProcessing/Shaders/Builtins/FinalPass.shader
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@ Shader "Hidden/PostProcessing/FinalPass"
Pass
{
HLSLPROGRAM
#pragma only_renderers gles
#pragma only_renderers gles3

#pragma multi_compile __ STEREO_INSTANCING_ENABLED STEREO_DOUBLEWIDE_TARGET
#pragma target es3.0
#pragma target 3.0

ENDHLSL
}
Expand Down