[2021.2] Adding _SURFACE_TYPE_TRANSPARENT keyword to URP and URP ShaderGraph shaders #4025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phi-lira
approved these changes
Mar 29, 2021
com.unity.render-pipelines.universal/Editor/ShaderGraph/Targets/UniversalTarget.cs
Outdated
Show resolved
Hide resolved
erikabar
approved these changes
Mar 30, 2021
aleksandrasdzikia
requested review from
aleksandrasdzikia
and removed request for
a team
eh-unity
approved these changes
Mar 31, 2021
| if (material.HasProperty(propertyID)) | ||
| { | ||
| float surfaceType = material.GetFloat(propertyID); | ||
| if (surfaceType >= 1.0f) |
There was a problem hiding this comment.
Should this be an enum instead of 1? If it's enable/disable i.e. 1/0 case, then I'd probably test against 0.
aleksandrasdzikia
approved these changes
Apr 2, 2021
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
This was referenced Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Currently we have a bug in SSAO where it being applied to transparent objects.
In order to fix that I've added a new keyword (
_SURFACE_TYPE_TRANSPARENT) to URP shaders. This is identical to the Keyword HDRP uses. A Material Upgrader was also added to properly set the keyword on materials.Example of the bug
Original scene
Same Scene with a opaque plane above it
Same Scene with a transparent plane (alpha = 1.0) above it
Testing
What has been tested
What needs testing
Automated testing
Yamato
-> when I take the PR out of draft mode