[ShaderGraph] Replace TextAsset usage with ShaderInclude #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 6, 2021 13:52
…extensions. Leaving the soft-check in for now.
joshua-davis
approved these changes
Apr 7, 2021
…adergraph currently.
phi-lira
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Trunk is moving Text files with shader related extensions to a separate asset type, ShaderInclude. This change originally caused a regression for us (which has been resolved), but we need to move to the new asset type. This change only effects Custom Function Node's asset selector for File sources, improving the filtering to exclude unsupported extensions by default.
Related issues/bugs:
https://jira.unity3d.com/browse/GSG-387
https://fogbugz.unity3d.com/f/cases/1324528/
https://fogbugz.unity3d.com/f/cases/1322466/
Note that our previous soft-checking for file extensions remains (as it impacts some ui/error msgs), as the goal of this PR is just to comply with Trunk.
Testing status
Manually checked asset type filtering on the ObjectField for all supported types. QA will do some additional testing. Extensions are further tested (to an extent) in the Custom Function Node related graphics tests.
Notes for Reviewers
Min version needed to be bumped for ShaderGraph, for which requires a min version bump for all of graphics.