New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VFX] Add Graphics Buffer support #4109
[VFX] Add Graphics Buffer support #4109
Conversation
This change requires C++ (cherry picked from commit 3c6f166)
(cherry picked from commit 76b908d)
(cherry picked from commit d9bc375)
…now) (cherry picked from commit 3f73450)
(cherry picked from commit 1cd0c6b)
…level for now) (cherry picked from commit 035780d)
(cherry picked from commit 75e9b92)
(cherry picked from commit 3ac5fde)
(cherry picked from commit 741d304)
(cherry picked from commit 27a8b7e)
(cherry picked from commit 8390dc3)
(cherry picked from commit 7669a7a)
…ity3d.com/unity/vfx-graphics/pull/89 (cherry picked from commit d3f2083)
(cherry picked from commit 66e5c7e)
It checks stride & count (cherry picked from commit c672220)
(cherry picked from commit 14fef70)
(cherry picked from commit 62e884f)
(cherry picked from commit f286fea)
(cherry picked from commit 8651ac3)
(cherry picked from commit 7245458)
(cherry picked from commit afb9ccf)
(cherry picked from commit e235d4b)
(cherry picked from commit e980c68)
(cherry picked from commit edd6bac)
(cherry picked from commit 7dae601)
(cherry picked from commit 3c171c4)
(cherry picked from commit 4fe6f9c)
(cherry picked from commit 24868a9)
(cherry picked from commit dce4897)
(cherry picked from commit e49e1e8)
com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionBuffer.cs
Outdated
Show resolved
Hide resolved
com.unity.visualeffectgraph/Editor/Inspector/VisualEffectEditor.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, no outstanding issues
test doc
# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
…Unity-Technologies/Graphics into vfx/feature/add-graphics-buffer-support
The needed change in C++ landed (see https://ono.unity3d.com/unity/unity/changeset/5676fbb6fbea) , launching Yamato on really last trunk : https://ono.unity3d.com/unity/unity/changeset/281d883a3da809b5684d799dea25486c92813302 (master didn't update the trunk head yet) on d9458b4 ⏳ |
…raphics-buffer-support
This reverts commit cf9467a.
This reverts commit f53c2d6.
Purpose of this PR
Adding Graphics Bufffer support defined by this technical design document.
Global approach ⬇️ (the generated code isn't up to date in this screenshot)
Add two operators :
⚠️ TODO : document newly added operator.
Expose VFXType with a new optionnal attribute :
Usage.GraphicsBuffer
& moved VFXType to runtime, sample of usage :Testing status
Adding a new graphic test which is displaying a set of rectangle, see this code : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/236/files#diff-6e84b835af122c8437c16eb04557d42aR178
Adding several editor test :
Tested locally some invalid VFXType :
Note : I'm expecting other error case but I tried to cover the most obvious possible incompatibilities.
I've run yamato to check the expected result :
Comments to reviewers
Known limitation :
Known issue (wip) :