Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UX issues in URP Rendering Debugger #4775

Merged
merged 1 commit into from Jun 15, 2021

Conversation

arttu-peltonen
Copy link
Contributor

Purpose of this PR

Fixes issues listed in https://fogbugz.unity3d.com/f/cases/1340619/

  • Rewrite logic for URP debug widget conditional hiding.
  • Hide Hue Tolerance & Saturation Tolerance fields for Default Luminance under Material Albedo validation.
  • Change Map Size to percentage of screen instead of pixels.

NOTE: Setting wireframe color is not fixed - there is no API to set this in SRP right now. Scene View wireframe modes seem to use a special wireframe shader on most backends, with Vulkan being the only one to support colored wireframe at API level.

Conditional UI for albedo validation:
hide-tolerance-ui

Map Size as percentage (default = 50%):
overlay-map-size-percentage


Testing status

Tested UI conditional behaves correctly both in Editor and Runtime. Map Size now respects viewport resolution as expected.

- Rewrite logic for URP debug widget conditional hiding.
- Hide Hue Tolerance & Saturation Tolerance fields for Default Luminance material validation.
- Change Map Size to percentage of screen.
@arttu-peltonen arttu-peltonen marked this pull request as ready for review June 3, 2021 12:26
@arttu-peltonen arttu-peltonen requested review from a team as code owners June 3, 2021 12:26
@TheoWong-pixel
Copy link

@oleks-k Might need to note in the docs later that Map size: is a percentage of the screen.
@arttu-peltonen I think we need to apply this change the HDRP mapsize implementations as well? unless that is already the case.

@arttu-peltonen
Copy link
Contributor Author

@arttu-peltonen I think we need to apply this change the HDRP mapsize implementations as well? unless that is already the case.

On HDRP, there is already "Lighting > Debug Overlay Screen Ratio" which goes from 0 to 1 (essentially a percentage), and scales the shadow debug overlay accordingly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

Copy link
Contributor

@Verasl Verasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would have liked the wireframe colour but this seems to be a Unity trunk change

@arttu-peltonen arttu-peltonen merged commit 8b352e5 into master Jun 15, 2021
@arttu-peltonen arttu-peltonen deleted the bugfix/debug-views-ux-bugs branch June 15, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants