Added support for ray binning for ray tracing in XR (case 1346374). #5038
Conversation
anisunity
requested review from
sebastienlagarde,
fabien-unity and
remi-chapelain
|
It appears that you made a non-draft PR! |
|
Launched the test on yamato. |
| // A really nice tip is to dispatch the rays as a 1D array instead of 2D, the performance difference has been measured. | ||
| uint dispatchSize = (uint)(bufferSizeX * bufferSizeY); | ||
| ctx.cmd.DispatchRays(data.parameters.gBufferRaytracingRT, m_RayGenGBufferBinned, dispatchSize, 1, 1); | ||
| ctx.cmd.DispatchRays(data.parameters.gBufferRaytracingRT, m_RayGenGBufferBinned, dispatchSize, (uint)data.parameters.viewCount, 1); |
There was a problem hiding this comment.
By convention we've been using the dispatch Z for the view count in all dispatch calls. Could you update this code ?
| @@ -176,6 +178,8 @@ void RayGenGBufferBinned() | |||
| // Grab the dimensions of the current raytrace shader | |||
| uint3 LaunchIndex = DispatchRaysIndex(); | |||
|
|
|||
| UNITY_XR_ASSIGN_VIEW_INDEX(LaunchIndex.y); | |||
There was a problem hiding this comment.
See previous comment about convention to use Z as view index.
| @@ -187,11 +191,11 @@ void RayGenGBufferBinned() | |||
|
|
|||
| // Read and unpack the coordiante to screen space coordinates | |||
| uint globalBinIndex = tileIndex * RAY_BINNING_TILE_SIZE * RAY_BINNING_TILE_SIZE + localTileIndex; | |||
| uint packedPixelCoordinate = _RayBinResult[globalBinIndex]; | |||
| uint packedPixelCoordinate = _RayBinResult[globalBinIndex + _RayBinViewOffset * LaunchIndex.y]; | |||
| uint2 currentPixelCoord = uint2((packedPixelCoordinate & 0xffff0000) >> 16, packedPixelCoordinate & 0xffff); | ||
|
|
||
| // If the local index of this pixel is beyond the valid count, no need to compute it | ||
| if (localTileIndex > _RayBinSizeResult[tileIndex]) | ||
| if (localTileIndex > _RayBinSizeResult[tileIndex + _RayBinTileViewOffset * LaunchIndex.y]) |
|
Review fixes done |
|
The following job should be run on every PR: It looks like you're changing an HDRP Package or project |
anisunity
force-pushed
the
HDRP/ray-binning-xr
branch
from
4668f0e
to
4672d56
Compare
https://fogbugz.unity3d.com/f/cases/1346374/
Support ray binning for RTR and RTGI in performance. Visually should not change anything.
Testing status
Most test pass locally, we need to run yamato to check if the fails are local or not.