New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a property on the HDRP asset to allow users to avoid ray tracing effects running at too low percentages (case 1342588). #5061
Conversation
The following job should be run on every PR: It looks like you're changing an HDRP Package or project It looks like you're changing the Core SRP Package or project |
It appears that you made a non-draft PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to run the formatter, otherwise looks good.
Formatting fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the documentation for this new checkbox in the dynamic resolution section of the HDRP asset.
Apart from that, feature is working well, it's not ideal but that's the best we can do for now.
If the screen percentage drops below the RT Half resolution threshold, all RT effects running at half resolution (RTR perf & RTGI perf) are force to full screen.
I added two new tests to prevent regression for this.
Basically, camera on the left uses DRS at 90% and the RT half threshold is 100%, so the half resolution get forced back to full resolution. Native camera on the right stays un-affected so keeps the half resolution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good 🟢
296bad2
to
462fa79
Compare
…g effects running at too low percentages (case 1342588).
462fa79
to
a551f41
Compare
hallelujah |
After some thinking, the only viable solution we found was to add a parameter to define until which sub-resolution half res ray tracing effects are allowed.
https://fogbugz.unity3d.com/f/cases/1342588/
Testing status
Due to a bug, tests are failing randomly even on master (locally). So we'll have to run on yamato and make sure it's fine