Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixing DLSS and TAU to be compatible with Blitter and Custom post process #5320

Closed
wants to merge 2 commits into from

Conversation

kecho
Copy link
Contributor

@kecho kecho commented Aug 9, 2021

Purpose of this PR

Fixing issues with custom post process, and HDCore Blit utility. This will make DLSS and TAU compatible wtih the blitter & custom post process.
Issue: Because the upscaled color has its own resolution, and there is a global RT handle scale state, Ive decided to make the color texture explicit in size of DLSS and TAU. This will make the Blitter work. Custom post processes still need to use _PostProcessSize in order to scale the color.

There will be some performance cost likely, 1 extra target, however because this resolution is immutable (the final resolution) I dont suspect there will be issues.

This PR will require a full pass from QA, and bloom + inspection on all post processes is still pending.

https://fogbugz.unity3d.com/f/cases/1352407/


Testing status

Pending.

@github-actions
Copy link

github-actions bot commented Aug 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_2021.2
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@kecho kecho changed the title making upsampled color a non scaled texture, improves architecture on… [WIP] Fixing DLSS and TAU to be compatible with Blitter and Custom post process Aug 9, 2021
@kecho kecho closed this Aug 10, 2021
@kecho kecho deleted the HDRP/FixBeforePostUpsampleWithFixedTextureSize branch August 10, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant