Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a parameter to control the vertical shape offset of the volumetric clouds (case 1358528) #5354

Merged
merged 2 commits into from Aug 17, 2021

Conversation

anisunity
Copy link
Contributor

https://fogbugz.unity3d.com/f/cases/1358528/
Added a slider to control the vertical shape offset.
Changed the name of the label of cloud offset to cloud map offset without renaming the variable, so no migration issue.

Testing status.
Made sure the label is correct
Played with the new slider, made sure moving it positively, makes the clouds go up (and aswell as the opposite).
shapeOffsetY
image
image

…ric clouds (case 1358528)

Renamed the Cloud Offset to Cloud Map Offset in the volumetric clouds volume component (case 1358528)
@anisunity anisunity added the HDRP label Aug 16, 2021
@anisunity anisunity self-assigned this Aug 16, 2021
@anisunity anisunity marked this pull request as ready for review August 16, 2021 16:16
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@anisunity
Copy link
Contributor Author

Changed Cloud Tiling to Cloud Map Tiling aswell

@anisunity
Copy link
Contributor Author

Trivial enough, no need for the tests, just the docs approval

Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested that the vertical offset looped correctly when on whole positive and negative number. (-1,0,1..etc).
  • Tested that already setup project updated properly.

For now, there's still going to be 3 distinct variable to avoid creating upgrade issue.
But as a improvement, theses offsets could be merged into a Vector3 with 3 inline float field to save space since there's already a lot of parameters (like the tiling / offset above)

image

@JulienIgnace-Unity JulienIgnace-Unity merged commit 74416a2 into master Aug 17, 2021
@JulienIgnace-Unity JulienIgnace-Unity deleted the HDRP/fix-1358528 branch August 17, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants