Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VFX][Fix] Update test and reference images for HDRP Decals #5625

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

ludovic-theobald
Copy link
Contributor

[VFX][Fix] Update test and reference images for HDRP Decals.


Purpose of this PR

This PR fixes an issue with the previous test 37_DecalsHDRP, where two planes were conflicting, leading to unstable tests.
The test and the reference images are now updated.


Comments to reviewers

N/A

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ludovic-theobald ludovic-theobald merged commit 914ed43 into master Sep 16, 2021
@ludovic-theobald ludovic-theobald deleted the vfx/fix/hdrp-decals-test-instability branch September 16, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants