Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HDRP][DXR] Fix wrong keyword for HDTemporalFilter #5638

Merged

Conversation

remi-chapelain
Copy link
Contributor

@remi-chapelain remi-chapelain commented Sep 13, 2021

Purpose of this PR

Following this PR, the wrong keyword has been used to fix the issue.


Comments to reviewers

Pair-tested with @anisunity

@remi-chapelain remi-chapelain marked this pull request as ready for review September 13, 2021 15:02
@github-actions github-actions bot added the HDRP label Sep 13, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@anisunity anisunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial, approved, can be merged

@remi-chapelain remi-chapelain merged commit e026766 into master Sep 13, 2021
@remi-chapelain remi-chapelain deleted the HDRP/fix-directional-raytraced-shadow-keyword branch September 13, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants