Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HDRP] APV Fix importing out-of-process asset creation error #5656

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

alelievr
Copy link
Member

@alelievr alelievr commented Sep 14, 2021

Purpose of this PR

Fix the error [Worker2] CreateSerializedAsset is not supported while importing out-of-process happening when the renderpipeline is created from an asset import (preview image generation).

Source: https://unity.slack.com/archives/C0108P9UH6H/p1631542174105900

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/hd%252Ftry-fix-apv-import-asset-bug/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk/8730109/job

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the SRP label Sep 14, 2021
@JulienIgnace-Unity JulienIgnace-Unity merged commit 1fbd894 into master Sep 16, 2021
@JulienIgnace-Unity JulienIgnace-Unity deleted the hd/try-fix-apv-import-asset-bug branch September 16, 2021 13:44
sebastienlagarde pushed a commit that referenced this pull request Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants