Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fogbugz # 1357722] Fixing DOF For DLSS #5660

Merged
merged 3 commits into from Sep 16, 2021
Merged

[Fogbugz # 1357722] Fixing DOF For DLSS #5660

merged 3 commits into from Sep 16, 2021

Conversation

kecho
Copy link
Contributor

@kecho kecho commented Sep 15, 2021 •
edited

Purpose of this PR

Fixing artifacts on DOF when DLSS was enabled, caused by having TAA logic accidentally enabled.

https://fogbugz.unity3d.com/f/cases/1357722/

Testing status

Tested using test scene. Dof fix:

Before
image

After
image

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@kecho kecho changed the title [WIP][Fogbugz # 1357722] Fixing DOF and AO For DLSS [Fogbugz # 1357722] Fixing DOF For DLSS Sep 15, 2021
@kecho kecho marked this pull request as ready for review September 15, 2021 18:38
@kecho kecho requested a review from a team September 15, 2021 18:38
@github-actions github-actions bot added the HDRP label Sep 15, 2021
FrancescoC-unity
FrancescoC-unity approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@FrancescoC-unity FrancescoC-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmavridis for awareness

@sebastienlagarde
Copy link
Collaborator

@qa: fix is trivial, merging

@sebastienlagarde sebastienlagarde merged commit f88bf9c into master Sep 16, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/DofAndAOFixForDLSS branch September 16, 2021 18:23
sebastienlagarde pushed a commit that referenced this pull request Sep 20, 2021
@kecho @sebastienlagarde
[Fogbugz # 1357722] Fixing DOF For DLSS #5660
e88d09f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@FrancescoC-unity FrancescoC-unity FrancescoC-unity approved these changes

Assignees
No one assigned
Labels
backported-2021.2 HDRP
Projects
None yet
Milestone
No milestone
3 participants
@kecho @sebastienlagarde @FrancescoC-unity