Fix issue with reflection probe normalization via APV #6140
Conversation
FrancescoC-unity
requested review from
alelievr,
sebastienlagarde,
JulienIgnace-Unity and
iM0ve
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
There was a problem hiding this comment.
What I tested:
- Checked the repro project to see the issue is indeed gone
- Checked Amalienborg project where realtime probes are used without APV. To see if maybe some unwanted changes were introduced outside APV system
- Checked ClassRoom project rebaking APV and probes to see if general APV issues were introduced
No issues related to the PR were found.
* Fixed references to probes not cleared when unloading a scene #5945 * [Fogbugz # 1365368] Fixing debug views for drs #5948 * [HDRP] Stacklit RTR: Fix issues with RTR reflections from stacklit materials #6103 * [HDRP] Lit coat ssr-rtr: Fix various issues with using SSR lighting with IBL fallback (case 1380351) #6106 * [HDRP] StackLit coat ssr-rtr light hierarchy and IBL fallback fixes. #6107 * AxF ssr-rtr: Implement refined light reflection hierarchy with separate weight for coat and base lobe to correctly fallback from SSR light to light reflection probes and also implement the same coat-traced light "reuse" as Lit for bottom lobe when roughnesses are similar. (#6108) This also cleans up the overlapping contributing reflection probes / dual normal setup problem in EvaluateBSDF_Env(). Based on previously discussed #4968. * Fix issue with reflection probe normalization via APV (#6140) * fix issue * - * [not ready] HDRP Scene Template: Bumped up IET framework version to 2.1 and better default layout for 1080p monitors (#6153) * bumped up iet framework to 2.1, created new 1080p and 4k friendly layout * Merge branch 'master' into hdrp-template-bumpup-iet-framework-version Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix custom pass utils in XR #6271 * Update reference screenshots Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: pierre-unity <39901544+pierre-unity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Fix for https://fogbugz.unity3d.com/f/cases/1373264/
Tricky issue to find. The issue was actually a collection of few smaller issues - weirder of which is the need of making prefab accept the changes done programmatically.
What did I test : the repro, tried to open and close the scene and verify that it's all still fine w.r.t normalization pre and post baking.
--- Note --
Normalization data will be gone even if the position of the probe doesn't change but other properties do, this is somewhat undesirable, but it is not a bug, going to add as a new feature we need to do.