Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an exception happening when the user doesn't set one of the renderers of a given LOD (case 1372965). #6202

Merged
merged 1 commit into from Nov 4, 2021

Conversation

anisunity
Copy link
Contributor

https://fogbugz.unity3d.com/f/cases/1372965/
Before 2021.2 No LOD support, so no need for the fix.
After 2021.2, C++ culling, no need for the fix.

Testing status
Pair tested on the repro case with @remi-chapelain

@anisunity anisunity self-assigned this Nov 4, 2021
@anisunity anisunity marked this pull request as ready for review November 4, 2021 11:49
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_2021.2
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair tested and already tested in this PR anyway !

@sebastienlagarde sebastienlagarde merged commit ffe31a7 into 2021.2/staging Nov 4, 2021
@sebastienlagarde sebastienlagarde deleted the 2021.2/fix-1372965 branch November 4, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants