Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update safety net trigger to avoid running it on .md changes #6270

Merged
merged 5 commits into from Nov 12, 2021

Conversation

theo-pnv
Copy link
Collaborator

@theo-pnv theo-pnv commented Nov 10, 2021

Purpose of this PR

Added an exception to the safety net pipeline trigger for md/documentation files that were in the last push.
To avoid rerunning the safety net if only markdown files were pushed (see https://unity.slack.com/archives/CU41BKSJF/p1636537478059700)


Testing status

steps:

  1. Update the trigger
  2. Wait for the safety net pipeline to kick off
  3. Push a random markdown update
  4. The safety net pipeline should not run
  5. Revert the md update

@theo-pnv theo-pnv requested a review from a team as a code owner November 10, 2021 14:33
@github-actions github-actions bot added the sdet label Nov 10, 2021
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@theo-pnv theo-pnv requested a review from a team as a code owner November 10, 2021 16:06
@theo-pnv theo-pnv removed the request for review from a team November 10, 2021 16:09
@theo-pnv
Copy link
Collaborator Author

^ See test run of above commit - the safety net did not kick off. So I will revert this dummy file, the PR is ready.

This reverts commit 88ea9f7.
@kivistikliis kivistikliis merged commit 5fe8393 into master Nov 12, 2021
@kivistikliis kivistikliis deleted the ant/avoid-rerunning-tests-if-md-changes branch November 12, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants