-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small Fix for Vortex subgraph addition #6332
Conversation
# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual change is minimal, however, the sugraphblock embedded in additionnal will probably deserve attention. I'm involving @Unity-Technologies/gfx-qa-vfx for visibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimal change on a VFX sample; no additional testing required.
Purpose of this PR
Small fix that prevents NaNs in Subgraph block Vortex (included in VFX Additions)
Testing status
N/A
Comments to reviewers
N/A