Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure single quality option for URP tests. #6372

Merged
merged 18 commits into from
Nov 26, 2021

Conversation

eh-unity
Copy link
Contributor

Purpose of this PR

Test only change to make sure all platforms are tested the same way and we have consistency across platforms.


Testing status

Local URP test cases seems work similarly as before.
It is expected that mobile tests break and the images need to be updated (remove inconsistency).


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@eh-unity eh-unity marked this pull request as ready for review November 23, 2021 20:09
@eh-unity eh-unity requested review from a team as code owners November 23, 2021 20:09
@eh-unity eh-unity merged commit 4b5b17c into master Nov 26, 2021
@eh-unity eh-unity deleted the universal/test-proj-remove-quality-opts branch November 26, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants