Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HDRP] update Metal reference screenshots #6507

Merged
merged 1 commit into from Dec 7, 2021
Merged

[HDRP] update Metal reference screenshots #6507

merged 1 commit into from Dec 7, 2021

Conversation

sebastienlagarde
Copy link
Collaborator

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

@sebastienlagarde sebastienlagarde merged commit cd397ac into master Dec 7, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-metal-screenshots branch December 7, 2021 10:57
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde changed the title reference (HDRP] update Metal reference screenshots Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde changed the title (HDRP] update Metal reference screenshots [HDRP] update Metal reference screenshots Dec 7, 2021
phi-lira added a commit that referenced this pull request Dec 9, 2021
@eh-unity @sebastienlagarde @phi-lira
Fix missing depth on overlay camera DoF (#6549)
15cd26e 
* Metal HDRP ref screenshots update (#6507)

* Fix typo in comment.

* Fix overlay depth.

* Add test case.

* Fix missing depth for overlay DoF. Workaround MacOS depth as wireframe driver bug.

URPasset has a depth texture checkbox, but that fixes the depth issue as well, but it's meant to be manual "force include depth" for case that can't be autodetected.
This one is correctly detected, but hardcode to not include depth (which is removed in this commit).

* Revert bug workaround. It's in another PR.

* Revert "Add test case."

This reverts commit c2e3067.

* Edit changelog.

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Co-authored-by: Felipe Lira <felipedrl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienIgnace-Unity JulienIgnace-Unity Awaiting requested review from JulienIgnace-Unity

Assignees
No one assigned
Labels
HDRP testing
Projects
None yet
Milestone
No milestone
1 participant
@sebastienlagarde