Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option for culling objects out of the ray tracing acceleration structure. #6715

Merged
merged 1 commit into from Jan 21, 2022

Conversation

anisunity
Copy link
Contributor

This PR adds the option for users to specify a culling mode for the ray tracing acceleration structure. This can be specified in the Ray Tracing Settings Volume. The user can chose between three options:

  • Extended frustum: This mirror the frustum and takes the bounding box of the result (default option)
  • Sphere: An additional option becomes available in the volume and allows the user to specify a radius.
  • None: Previous state

Testing Status
Three new tests were created to cover this new feature.
image

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@remi-chapelain remi-chapelain requested a review from a team January 12, 2022 08:43
Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has already been pair tested while making the precious automated tests.
Looking good. ✔️

Copy link
Collaborator

@sebastienlagarde sebastienlagarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleas add an entry in What's new for this thanks

@anisunity anisunity marked this pull request as ready for review January 21, 2022 10:04
@anisunity
Copy link
Contributor Author

What is new updated, all DXR tests are green locally all good!

@anisunity anisunity merged commit 2da975b into master Jan 21, 2022
@anisunity anisunity deleted the HDRP/rt-culling branch January 21, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants