Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gles/fix shader compilation errors #6970

Merged
merged 3 commits into from Feb 8, 2022

Conversation

rjonaitis
Copy link
Contributor

Purpose of this PR

Fixes URP shader compilation errors during building for GLES3/GLES2 platforms https://fogbugz.unity3d.com/f/cases/1388668/


Testing status

Manual test of building empty project with URP for Android platform with GLES3/GLES2 APIs


Comments to reviewers

Notes for the reviewers you have assigned.

@rjonaitis rjonaitis requested a review from a team as a code owner February 2, 2022 20:52
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the SRP label Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@rjonaitis rjonaitis merged commit 4d42743 into master Feb 8, 2022
@rjonaitis rjonaitis deleted the gles/fix-shader-compilation-errors branch February 8, 2022 12:56
unity-emilk pushed a commit that referenced this pull request Apr 29, 2022
backport of #6970

Fixes URP shader compilation errors during building for GLES2 platforms https://fogbugz.unity3d.com/f/cases/1388668/
unity-emilk pushed a commit that referenced this pull request Apr 29, 2022
backport of #6970

Fixes URP shader compilation errors during building for GLES2 platforms https://fogbugz.unity3d.com/f/cases/1388668/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants