Core SRP CPU Performance Improvements #7657
Open
+35
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some simple performance improvements. Would be good to take these into new commits as well and could be backported Since nothing changed for the end user I did not make changelog edits. Is that necessary? Improved CPU performance with: - Remove indirect gameObject call - Re order vector calculations - Merge .position and .rotation into .SetPositionAndRotation - Use TryGetComponent to reduce garbage allocation - Use native length and count instead of LINQ - Merge if-else return into return - Use AddRange - Simplify string comparison
RSlysz
approved these changes
Sep 14, 2022
| @@ -890,7 +890,7 @@ static string GetTextureAutoName(int width, int height, string format, TextureDi | |||
| temp = string.Format("{0}x{1}{2}_{3}", width, height, mips ? "_Mips" : "", format); | |||
| else | |||
| temp = string.Format("{0}x{1}x{2}{3}_{4}", width, height, depth, mips ? "_Mips" : "", format); | |||
| temp = String.Format("{0}_{1}_{2}", name == "" ? "Texture" : name, (dim == TextureDimension.None) ? "" : dim.ToString(), temp); | |||
| temp = String.Format("{0}_{1}_{2}", name?.Length == 0 ? "Texture" : name, (dim == TextureDimension.None) ? "" : dim.ToString(), temp); | |||
There was a problem hiding this comment.
At this point, to add the null check, it is even better to rely on String.IsNullOrEmpty
Suggested change
| temp = String.Format("{0}_{1}_{2}", name?.Length == 0 ? "Texture" : name, (dim == TextureDimension.None) ? "" : dim.ToString(), temp); | |
| temp = String.Format("{0}_{1}_{2}", String.IsNullOrEmpty(name) ? "Texture" : name, (dim == TextureDimension.None) ? "" : dim.ToString(), temp); |
There was a problem hiding this comment.
I benchmarked it and isNullOrEmpty actually does a string comparison instead of a null check, so is slower than this!
It is more readable however, so just say what you prefer. I can share the benchmark numbers tomorrow, but it was more than I expected
There was a problem hiding this comment.
Please do, I am curious about the difference.
arttu-peltonen
approved these changes
Sep 15, 2022
|
Made a public post for others to see. Could not test everything due to time limits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simple performance improvements. Would be good to take these into new commits as well and could be backported Since nothing changed for the end user.
I did not make changelog edits. Is that necessary?
Improved CPU performance with:
Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Improve CPU performance with minor fixes
Testing status
Describe what manual/automated tests were performed for this PR
No major changes made to code
Comments to reviewers
Notes for the reviewers you have assigned.
Do I need to add changelog changes?
Can this be backported?