Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: CI failing - CleanConsole test showed warning (ISXB-669) #1787

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

ritamerkl
Copy link
Collaborator

Description

The CI failed for the TestCleanConsole Generated Test, because a warning appeared in the console. To fix the warning the referenced .png file from the InputActionsTreeViewItem.uxml had to be referenced in the uss file. The inline referencing can break sometimes, more information can be found in the ticket (see ticket).

Changes made

fixed:

  • "dependency isn't used" warning fixed for CI tests

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great you found a fix for this.

@ritamerkl ritamerkl merged commit 4c61a30 into develop Nov 1, 2023
80 checks passed
@ritamerkl ritamerkl deleted the ISXB-669-fixed-uxml-warning-for-CI branch November 1, 2023 16:21
jamesmcgill pushed a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants