NEW: Add APIs to change or erase existing bindings on actions. #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-piconi
approved these changes
Apr 3, 2019
jechter
reviewed
Apr 8, 2019
| @@ -225,6 +225,49 @@ private static int AddBindingInternal(InputActionMap map, InputBinding binding) | |||
| return bindingIndex; | |||
| } | |||
|
|
|||
| public static BindingSyntax ChangeBinding(this InputAction action, int index) | |||
There was a problem hiding this comment.
What's the use case for using indexes? Iterating over all bindings?
There was a problem hiding this comment.
Stuff like
for (var i = 0; i < myAction.bindings.Count; ++i)
if (myAction.bindings[i].SomeKindOfCheck)
myAction.ChangeBinding(i)....;
jechter
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to https://forum.unity.com/threads/interaction-adding-interaction-on-an-action-during-runtime.651187/.