Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: PlayerInput.Instantiate not handling control schemes correctly. #796

Merged
merged 4 commits into from Aug 23, 2019

Conversation

Rene-Damm
Copy link
Contributor

@Rene-Damm Rene-Damm commented Aug 20, 2019

User report: https://forum.unity.com/threads/playerinput-instantiate-ignores-controller-schemes-for-multiplayer-with-players-on-same-device.730868/

The following used to result in two players with both having all keyboard bindings from all control schemes active rather than one using "KeyboardWASD" only and the other using "KeyboardArrows" only. Was a problem in InputUser where the order in which actions were set on a user WRT when its control scheme was set ended up mattering when it shouldn't.

PlayerInput.Instantiate(player, controlScheme: "Keyboard WASD", pairWithDevice: Keyboard.current);
PlayerInput.Instantiate(player, controlScheme: "Keyboard Arrows", pairWithDevice: Keyboard.current);

@Rene-Damm Rene-Damm merged commit 9150693 into develop Aug 23, 2019
@Rene-Damm Rene-Damm deleted the fix-split-keyboard branch August 23, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants