FIX: Custom devices lost on domain reload (case 1192379). #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-piconi
approved these changes
Oct 24, 2019
jechter
approved these changes
Oct 24, 2019
|
@jechter I found my changes broke some tests and were actually partially incorrect. Added some more changes to attempt to properly fix the problem. Also added some docs to add some more details about how devices get (re)created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First piece of
[InitializeOnLoad]code accessing the input system would cause devices that couldn't be instantly recreated to be lost even if a neededRegisterLayoutcall would come in later during initialization after domain reload.