Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-0000: Add FlyAround sample scene #926

Merged
merged 6 commits into from Mar 11, 2024
Merged

CMCL-0000: Add FlyAround sample scene #926

merged 6 commits into from Mar 11, 2024

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Jan 30, 2024

Purpose of this PR

I'm tired of being asked on the forums about how to do a fly-around camera, so here is a sample that shows it.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.68%. Comparing base (c97b6a7) to head (9d98ae1).
Report is 11 commits behind head on main.

❗ Current head 9d98ae1 differs from pull request most recent head 305bfb4. Consider uploading reports for the commit 305bfb4 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #926   +/-   ##
=======================================
  Coverage   26.67%   26.68%           
=======================================
  Files         246      246           
  Lines       27572    27563    -9     
=======================================
- Hits         7356     7355    -1     
+ Misses      20216    20208    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntoineCharton
Copy link
Collaborator

Screenshot 2024-01-31 at 3 28 45 PM Is it expected? 2023.2 hdrp input system.

Default material assigned to the fly around object.
Screenshot 2024-01-31 at 3 29 29 PM

@glabute
Copy link
Collaborator Author

glabute commented Jan 31, 2024

The warning is fixed on the other PR.
Nice catch on the material

@unity-cla-assistant
Copy link

unity-cla-assistant commented Mar 8, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@AntoineCharton AntoineCharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@glabute
Copy link
Collaborator Author

glabute commented Mar 8, 2024

Did you have some issues about the control mappings? Also, does it make sense on both keyboard/mouse and gamepad?

@glabute glabute merged commit 5593292 into main Mar 11, 2024
3 checks passed
@glabute glabute deleted the dev/FlyAroundSample branch March 11, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants