New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMCL-0000: Improvements to PR-928: Spline position units #929
Commits on Feb 3, 2024
-
Update CinemachineSplineDolly.cs & CinemachineSplineDollyEditor.cs
* Converted PositionUnits to Property
Commits on Feb 4, 2024
-
Update
SplineContainerExtensions.cs
* Created `ConvertDistance` method & friends (Thanks Wybren van den Akker for helping with math)
-
Update
SplineContainerExtensions.cs
* Added `ArgumentOutOfRangeException`s to internal code (could theoretically be accessed if users use ASMREFs)
-
Update
CinemachineTrackedDolly.cs
(UpgradeToCm3)* Changed the order of upgrading. `m_Path` has to be done first, `CinemachineSplineDolly` needs it before its `PositionUnits` is set.
-
Update
SplineDollyCameraTest.cs
* Added Unit Tests for my changes
-
-
Update
SplineContainerExtensions.cs
* Added XML Documentation to new Conversion methods.
-
Update
SplineDollyCameraTest.cs
* `PositionUnits_DoesNotChangeCameraPosition_WhenPositionUnitsSame()` - Added additional asserts, not very important because as the code is now even just one should be enough. But still.
-
Update
SplineContainerExtensions.cs
* Fixed small error made in XML comments
-
Update
CinemachineSplineDollyEditor.cs
&CinemachineSplineDolly.cs
* Moved my positionUnitsBackingfield change tracking from OnValidate to the custom editor.