Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-0000: Improvements to PR-928: Spline position units #929

Merged
merged 18 commits into from Mar 11, 2024

Commits on Feb 3, 2024

  1. Update CinemachineSplineDolly.cs & CinemachineSplineDollyEditor.cs

    * Converted PositionUnits to Property
    Walter-Hulsebos committed Feb 3, 2024
    Copy the full SHA
    5d4ac42 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Update SplineContainerExtensions.cs

    * Created `ConvertDistance` method & friends
    (Thanks Wybren van den Akker for helping with  math)
    Walter-Hulsebos committed Feb 4, 2024
    Copy the full SHA
    b6dc969 View commit details
    Browse the repository at this point in the history
  2. Update SplineContainerExtensions.cs

    * Added `ArgumentOutOfRangeException`s to internal code (could theoretically be accessed if users use ASMREFs)
    Walter-Hulsebos committed Feb 4, 2024
    Copy the full SHA
    1b3da28 View commit details
    Browse the repository at this point in the history
  3. Update CinemachineTrackedDolly.cs (UpgradeToCm3)

    * Changed the order of upgrading. `m_Path` has to be done first, `CinemachineSplineDolly` needs it before its `PositionUnits` is set.
    Walter-Hulsebos committed Feb 4, 2024
    Copy the full SHA
    5e3c2d3 View commit details
    Browse the repository at this point in the history
  4. Update SplineDollyCameraTest.cs

    * Added Unit Tests for my changes
    Walter-Hulsebos committed Feb 4, 2024
    Copy the full SHA
    1799c7a View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    beaad5c View commit details
    Browse the repository at this point in the history
  6. Update SplineContainerExtensions.cs

    * Added XML Documentation to new Conversion methods.
    Walter-Hulsebos committed Feb 4, 2024
    Copy the full SHA
    371b1ce View commit details
    Browse the repository at this point in the history
  7. Update SplineDollyCameraTest.cs

    * `PositionUnits_DoesNotChangeCameraPosition_WhenPositionUnitsSame()` - Added additional asserts, not very important because as the code is now even just one should be enough. But still.
    Walter-Hulsebos committed Feb 4, 2024
    Copy the full SHA
    70d2c64 View commit details
    Browse the repository at this point in the history
  8. Update SplineContainerExtensions.cs

    * Fixed small error made in XML comments
    Walter-Hulsebos committed Feb 4, 2024
    Copy the full SHA
    4d10781 View commit details
    Browse the repository at this point in the history
  9. Update CinemachineSplineDollyEditor.cs & CinemachineSplineDolly.cs

    * Moved my positionUnitsBackingfield change tracking from OnValidate to the custom editor.
    Walter-Hulsebos committed Feb 4, 2024
    Copy the full SHA
    3365c16 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Copy the full SHA
    2f6a65d View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    glabute committed Feb 6, 2024
    Copy the full SHA
    271b5ad View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Copy the full SHA
    d9eac2b View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. add legacy support

    glabute committed Feb 23, 2024
    Copy the full SHA
    f816082 View commit details
    Browse the repository at this point in the history
  2. propertydrawer layout tweak

    glabute committed Feb 23, 2024
    Copy the full SHA
    b9594ba View commit details
    Browse the repository at this point in the history
  3. handle prefabs better

    glabute committed Feb 23, 2024
    Copy the full SHA
    37d48c3 View commit details
    Browse the repository at this point in the history
  4. clean up spline samples

    glabute committed Feb 23, 2024
    Copy the full SHA
    efbb4f1 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Copy the full SHA
    ded4372 View commit details
    Browse the repository at this point in the history